-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Extensions - removes abc.Iterable definition #1320
Linux: Extensions - removes abc.Iterable definition #1320
Conversation
`hlist_head` is missing an implementation for `collections.abc.Iterable`, resulting in a crash at runtime. This fixes the issue by providing the required `__iter__` implementation for `hlist_head`.
Hey @dgmcdona it was just removed :) ... good catch anyway but the proposed fix is not correct. It's actually the other way around, we have to remove |
By the way, |
Sounds good, thanks @gcmoreira ! I'll close this one, then. |
Oh we can fix this and take advantage of your finding here if you want. You should remove the hlist_head |
Per @gcmoreira this is the correct fix vs the one previously proposed, since self.vol.member_name cannot be used as the member name to iterate this type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy if you guys are...
hlist_head
is missing an implementation forcollections.abc.Iterable
, resulting in a crash at runtime. This fixes the issue by providing the required__iter__
implementation forhlist_head
.